From bb568a4cff6c6271169c869ccdc5db80f06e92ff Mon Sep 17 00:00:00 2001 From: David Date: Mon, 14 Nov 2022 10:52:02 +0100 Subject: [PATCH] enfernt den redudanten Code. Statt eines ganzen Methode Definition in jeder Datei, wurde die Methode im template.js definiert, und sie wurde in jeder Datei wo wird sie verwendet, importiert --- .../chapter11/dataTransformMapFilterReduce.js | 9 ++------- javascript/Javascript Expert/chapter11/find.js | 11 +---------- javascript/Javascript Expert/chapter11/findIndex.js | 11 +---------- javascript/Javascript Expert/chapter11/map.js | 9 ++------- .../Javascript Expert/chapter11/methodChaining.js | 11 +---------- javascript/Javascript Expert/chapter11/package.json | 3 +++ javascript/Javascript Expert/chapter11/reduce.js | 12 ++---------- .../chapter11/someAndEveryMethod.js | 12 +----------- javascript/Javascript Expert/chapter11/template.js | 12 +++++++++++- 9 files changed, 24 insertions(+), 66 deletions(-) create mode 100644 javascript/Javascript Expert/chapter11/package.json diff --git a/javascript/Javascript Expert/chapter11/dataTransformMapFilterReduce.js b/javascript/Javascript Expert/chapter11/dataTransformMapFilterReduce.js index 1a4149f..326463c 100644 --- a/javascript/Javascript Expert/chapter11/dataTransformMapFilterReduce.js +++ b/javascript/Javascript Expert/chapter11/dataTransformMapFilterReduce.js @@ -1,3 +1,5 @@ +import { randomIntNumbers as randomNumbers } from "./template.js"; + const account1 = { owner: "David Aster", movements: [200, 450, -400, 3000, -650, -130, 70, 1300], @@ -26,13 +28,6 @@ const account4 = { pin: 4444, }; -const randomNumbers = function (n) { - let arr = []; - for (let i = 0; i < n; i++) { - arr.push(Math.trunc(Math.random() * 1000)); - } - return arr; -}; console.log("Ursprüngliche Werte"); var arr = randomNumbers(20); // werden ursprüngliche Werte geändert, in unserem Fall curr * 2 diff --git a/javascript/Javascript Expert/chapter11/find.js b/javascript/Javascript Expert/chapter11/find.js index 78f1dd9..850ff35 100644 --- a/javascript/Javascript Expert/chapter11/find.js +++ b/javascript/Javascript Expert/chapter11/find.js @@ -1,13 +1,4 @@ -const randomIntNumbers = n => { - let transaktionen = []; - for (let i = 0; i < n; i++) { - const rndNum = Math.random() * 1000; - rndNum > Math.random() * 1000 - ? transaktionen.push(Math.trunc(rndNum)) - : transaktionen.push(-Math.trunc(rndNum)); - } - return transaktionen; -}; +import { randomIntNumbers } from "./template.js"; const movements = randomIntNumbers(14); console.log(movements); diff --git a/javascript/Javascript Expert/chapter11/findIndex.js b/javascript/Javascript Expert/chapter11/findIndex.js index f2c0bf9..6eb8331 100644 --- a/javascript/Javascript Expert/chapter11/findIndex.js +++ b/javascript/Javascript Expert/chapter11/findIndex.js @@ -1,13 +1,4 @@ -const randomIntNumbers = n => { - let transaktionen = []; - for (let i = 0; i < n; i++) { - const rndNum = Math.random() * 1000; - rndNum > Math.random() * 1000 - ? transaktionen.push(Math.trunc(rndNum)) - : transaktionen.push(-Math.trunc(rndNum)); - } - return transaktionen; -}; +import { randomIntNumbers } from "./template.js"; const movements = randomIntNumbers(16); diff --git a/javascript/Javascript Expert/chapter11/map.js b/javascript/Javascript Expert/chapter11/map.js index 4da3e9b..9055bd2 100644 --- a/javascript/Javascript Expert/chapter11/map.js +++ b/javascript/Javascript Expert/chapter11/map.js @@ -1,10 +1,5 @@ -const randomNumbers = n => { - let arr = []; - for (let i = 0; i < n; i++) { - arr.push(Math.trunc(Math.random() * 1000)); - } - return arr; -}; +import { randomIntNumbers as randomNumbers } from "./template.js"; + var arr = randomNumbers(15); console.log("EUR", arr); diff --git a/javascript/Javascript Expert/chapter11/methodChaining.js b/javascript/Javascript Expert/chapter11/methodChaining.js index d4fcf65..08bac98 100644 --- a/javascript/Javascript Expert/chapter11/methodChaining.js +++ b/javascript/Javascript Expert/chapter11/methodChaining.js @@ -1,13 +1,4 @@ -const randomIntNumbers = n => { - let transaktionen = []; - for (let i = 0; i < n; i++) { - const rndNum = Math.random() * 1000; - rndNum > Math.random() * 1000 - ? transaktionen.push(Math.trunc(rndNum)) - : transaktionen.push(-Math.trunc(rndNum)); - } - return transaktionen; -}; +import { randomIntNumbers } from "./template.js"; const eurToUsd = 1.1; diff --git a/javascript/Javascript Expert/chapter11/package.json b/javascript/Javascript Expert/chapter11/package.json new file mode 100644 index 0000000..3dbc1ca --- /dev/null +++ b/javascript/Javascript Expert/chapter11/package.json @@ -0,0 +1,3 @@ +{ + "type": "module" +} diff --git a/javascript/Javascript Expert/chapter11/reduce.js b/javascript/Javascript Expert/chapter11/reduce.js index 449a114..fc3acab 100644 --- a/javascript/Javascript Expert/chapter11/reduce.js +++ b/javascript/Javascript Expert/chapter11/reduce.js @@ -1,13 +1,5 @@ -const randomIntNumbers = n => { - let transaktionen = []; - for (let i = 0; i < n; i++) { - const rndNum = Math.random() * 1000; - rndNum > Math.random() * 1000 - ? transaktionen.push(Math.trunc(rndNum)) - : transaktionen.push(-Math.trunc(rndNum)); - } - return transaktionen; -}; +import { randomIntNumbers } from "./template.js"; + const arrOfTrans = randomIntNumbers(10); console.log(`Alle Transaktionen: ${arrOfTrans}`); diff --git a/javascript/Javascript Expert/chapter11/someAndEveryMethod.js b/javascript/Javascript Expert/chapter11/someAndEveryMethod.js index bb47ca9..bab9f91 100644 --- a/javascript/Javascript Expert/chapter11/someAndEveryMethod.js +++ b/javascript/Javascript Expert/chapter11/someAndEveryMethod.js @@ -1,3 +1,4 @@ +import { randomIntNumbers } from "./template.js"; const obst = ["apfel", "erdbeere", "mango", "banane", "orange"]; function checkVerfuegbarkeit(obst, val) { @@ -7,17 +8,6 @@ function checkVerfuegbarkeit(obst, val) { console.log(checkVerfuegbarkeit(obst, "orange")); console.log(checkVerfuegbarkeit(obst, "heidelbeere")); -const randomIntNumbers = n => { - let transaktionen = []; - for (let i = 0; i < n; i++) { - const rndNum = Math.random() * 1000; - rndNum > Math.random() * 1000 - ? transaktionen.push(Math.trunc(rndNum)) - : transaktionen.push(-Math.trunc(rndNum)); - } - return transaktionen; -}; - const deposits = randomIntNumbers(50); const anyDeposits = deposits.some(deposit => deposit > 0); console.log(anyDeposits); diff --git a/javascript/Javascript Expert/chapter11/template.js b/javascript/Javascript Expert/chapter11/template.js index 7b7636f..2d95609 100644 --- a/javascript/Javascript Expert/chapter11/template.js +++ b/javascript/Javascript Expert/chapter11/template.js @@ -1,4 +1,3 @@ -"use strict"; // Data const account1 = { owner: "David Aster", @@ -69,3 +68,14 @@ const currencies = new Map([ const movements = [200, 450, -400, 3000, -650, -130, 70, 1300]; ///////////////////////////////////////////////// + +export const randomIntNumbers = n => { + let transaktionen = []; + for (let i = 0; i < n; i++) { + const rndNum = Math.random() * 1000; + rndNum > Math.random() * 1000 + ? transaktionen.push(Math.trunc(rndNum)) + : transaktionen.push(-Math.trunc(rndNum)); + } + return transaktionen; +};